[vlc-devel] [PATCH] Fix the latest mingw-w64 crt trunk

Martell Malone martellmalone at gmail.com
Tue Nov 18 16:40:25 CET 2014


>
> That does not seem right. By that line of thinking, we would need to
> include <time.h> everywhere, and yet clearly we don't.


Yes I understand what you mean it does look strange at first look.

To me it seems vlc_fixups.h is already making an assumption.
It assumes that if HAVE_GMTIME_R and HAVE_LOCALTIME_R are both defined then
you already have a prototype for the time function.
I can't speak for other platforms but this is not the case for mingw-w64

On Tue, Nov 18, 2014 at 3:28 PM, Rémi Denis-Courmont <remi at remlab.net>
wrote:

> Le 2014-11-18 18:20, Martell Malone a écrit :
>
>> On mingw-w64 we still need time.h to be included in vlc_fixups.h
>> otherwise we will get undefined references to the time function
>> itself.
>>
>
> That does not seem right. By that line of thinking, we would need to
> include <time.h> everywhere, and yet clearly we don't.
>
>
> --
> Rémi Denis-Courmont
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20141118/655d94e4/attachment.html>


More information about the vlc-devel mailing list