[vlc-devel] [PATCH] Fix the latest mingw-w64 crt trunk

Rémi Denis-Courmont remi at remlab.net
Tue Nov 18 16:53:03 CET 2014


Le 2014-11-18 18:40, Martell Malone a écrit :
>> That does not seem right. By that line of thinking, we would need to
>> include <time.h> everywhere, and yet clearly we dont.
>
> Yes I understand what you mean it does look strange at first look.
>
> To me it seems vlc_fixups.h is already making an assumption.
> It assumes that if HAVE_GMTIME_R and HAVE_LOCALTIME_R are both
> defined then you already have a prototype for the time function.

No. It assumes that if both gmtime_r() and localtime_r() are present, 
then <vlc_fixups.h> does not depend on <time.h>.

<vlc_fixups.h> does not use the time() function anywhere anyhow.

-- 
Rémi Denis-Courmont



More information about the vlc-devel mailing list