[vlc-devel] [PATCH] Fix the latest mingw-w64 crt trunk

Martell Malone martellmalone at gmail.com
Tue Nov 18 16:59:22 CET 2014


>
> <vlc_fixups.h> does not use the time() function anywhere anyhow.


I will rebuild without the patch now.
I need get error for us to find the solution.
You may indeed be right and the fix lies somewhere else.
I will be back shortly will the error :)

On Tue, Nov 18, 2014 at 3:53 PM, Rémi Denis-Courmont <remi at remlab.net>
wrote:

> Le 2014-11-18 18:40, Martell Malone a écrit :
>
>> That does not seem right. By that line of thinking, we would need to
>>> include <time.h> everywhere, and yet clearly we dont.
>>>
>>
>> Yes I understand what you mean it does look strange at first look.
>>
>> To me it seems vlc_fixups.h is already making an assumption.
>> It assumes that if HAVE_GMTIME_R and HAVE_LOCALTIME_R are both
>> defined then you already have a prototype for the time function.
>>
>
> No. It assumes that if both gmtime_r() and localtime_r() are present, then
> <vlc_fixups.h> does not depend on <time.h>.
>
> <vlc_fixups.h> does not use the time() function anywhere anyhow.
>
>
> --
> Rémi Denis-Courmont
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20141118/dd172b06/attachment.html>


More information about the vlc-devel mailing list