[vlc-devel] [PATCH] protobuf: build protoc where necessary

[Rémi Denis-Courmont]

Le mardi 7 octobre 2014, 15:38:31 Sean McGovern a écrit :
> ---
>  contrib/src/protobuf/rules.mak |    7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/contrib/src/protobuf/rules.mak b/contrib/src/protobuf/rules.mak
> index 9fbd339..84f9916 100644
> --- a/contrib/src/protobuf/rules.mak
> +++ b/contrib/src/protobuf/rules.mak
> @@ -21,6 +21,11 @@ ifdef HAVE_WIN32
>  endif
>  	$(MOVE)
> 
> +PROTOCONF := $(HOSTCONF)
> +ifeq ($(shell protoc --version >/dev/null 2>&1 || echo FAIL),)
> +PROTOCONF += --with-protoc=protoc
> +endif
> +

Cross-building a native tool is not going to help, at least not when cross-
compiling VLC. Instead, you need to build a cross-tool. That does not belongs 
in extras/tools or in your distribution.

The patch seems wrong to me.

-- 
Rémi Denis-Courmont
http://www.remlab.net/