[vlc-devel] [PATCH] protobuf: build protoc where necessary

[gseanmcg at gmail.com]

Hi Rémi,

This patch has nothing to do with cross compilation -- that is already covered in this contrib but not visible in this patch because of too few lines of context.

What this patch does cover is building a native tool on systems that don't ship with it (OS X and Windows at the very least). Currently, all the buildslaves lacking this tool are failing the contrib build jobs.

-- Sean McG.
Sent on the TELUS Mobility network with BlackBerry

-----Original Message-----
From: Rémi Denis-Courmont <remi at remlab.net>
Sender: "vlc-devel" <vlc-devel-bounces at videolan.org>Date: Tue, 07 Oct 2014 23:28:10 
To: <vlc-devel at videolan.org>
Reply-To: Mailing list for VLC media player developers <vlc-devel at videolan.org>
Subject: Re: [vlc-devel] [PATCH] protobuf: build protoc where necessary

Le mardi 7 octobre 2014, 15:38:31 Sean McGovern a écrit :
> ---
>  contrib/src/protobuf/rules.mak |    7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/contrib/src/protobuf/rules.mak b/contrib/src/protobuf/rules.mak
> index 9fbd339..84f9916 100644
> --- a/contrib/src/protobuf/rules.mak
> +++ b/contrib/src/protobuf/rules.mak
> @@ -21,6 +21,11 @@ ifdef HAVE_WIN32
>  endif
>  	$(MOVE)
> 
> +PROTOCONF := $(HOSTCONF)
> +ifeq ($(shell protoc --version >/dev/null 2>&1 || echo FAIL),)
> +PROTOCONF += --with-protoc=protoc
> +endif
> +

Cross-building a native tool is not going to help, at least not when cross-
compiling VLC. Instead, you need to build a cross-tool. That does not belongs 
in extras/tools or in your distribution.

The patch seems wrong to me.

-- 
Rémi Denis-Courmont
http://www.remlab.net/

_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
https://mailman.videolan.org/listinfo/vlc-devel