[vlc-devel] [PATCH] mediacodec: no software rendering before api 18

[Thomas Guillem]

I did that because I experienced some crashes with mediacodec sw
rendering with pre android 4.3 devices.

But you are right, I have a better (and obvious) idea to fix it. (see
next patch)

On Wed, Oct 22, 2014, at 21:11, Edward Wang wrote:
> 
> 
> Le 22 octobre 2014 10:37:07 HAP, "Martin Storsjö" <martin at martin.st> a
> écrit :
> >On Wed, 22 Oct 2014, Thomas Guillem wrote:
> >
> >> Avoid crashes by rendering unknown YUV buffers since "color-format"
> >can't be
> >> trusted before api 18.
> >> ---
> >> modules/codec/omxil/android_mediacodec.c | 9 ++++++++-
> >> 1 file changed, 8 insertions(+), 1 deletion(-)
> >
> >Why should we disallow this completely? It works just fine on a number
> >of 
> >devices. Sure, not reliable across untested devices, but that's why we 
> >have the device whitelist so we don't enable it automatically on random
> >
> >devices, so it's only a problem if you intentionally enable the option.
> >
> >// Martin
> 
> I agree with Martin here, especially after considering the presence of
> the whitelist.
> 
> Regards,
> Edward 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel