[vlc-devel] [vlc-commits] swscale: scale the whole picture (fixes #12085)

[Hannes Domani]

Hello

Rémi Denis-Courmont <git at videolan.org> schrieb am 22:06 Montag, 20.Oktober 2014:
> vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Mon Oct 20 22:17:33 2014 +0300| [44d4685b1ca4d1b58c4ce77d479103d482be5d14] | committer: Rémi Denis-Courmont
> 
> swscale: scale the whole picture (fixes #12085)
> 
> ...not just the visible part. So that cropping still works even though
> the visible part of the input and output format typically do not match.
> 
> > http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=44d4685b1ca4d1b58c4ce77d479103d482be5d14


Since this commit I have crashes when playing these 2 files:

- http://streams.videolan.org/issues/6860/10s.rgb-rgb.matrix-bgr.cfr18.mp4

(gdb) bt
#0  0x179a3579 in gbr24ptopacked32 (src=src at entry=0x1803f5b0, srcStride=srcStride at entry=0x1803f5c8, dst=<optimized out>, dstStride=7680, srcSliceH=srcSliceH at entry=1026, alpha_first=0,
width=width at entry=1920) at libswscale/swscale_unscaled.c:423
#1  0x179a8890 in planarRgbToRgbWrapper (c=0x1c1097a0, src=0x1803f640, srcStride=0x1803f660, srcSliceY=0, srcSliceH=1026, dst=0x1803f650, dstStride=0x1803f670) at libswscale/swscale_unscaled.c:476
#2  0x179a96ce in sws_scale (c=c at entry=0x1c1097a0, srcSlice=srcSlice at entry=0x1803f6c8, srcStride=srcStride at entry=0x1803f6d8, srcSliceY=srcSliceY at entry=0, srcSliceH=srcSliceH at entry=1026,
dst=dst at entry=0x1803f6e8, dstStride=dstStride at entry=0x1803f6f8) at libswscale/swscale_unscaled.c:1291
#3  0x179a1a04 in Convert (p_filter=p_filter at entry=0x15702b2c, ctx=0x1c1097a0, p_dst=p_dst at entry=0x156f6090, p_src=p_src at entry=0x156fa408, i_height=i_height at entry=1026,
i_plane_count=i_plane_count at entry=3, b_swap_uvi=b_swap_uvi at entry=false, b_swap_uvo=false) at ../../extras/package/win32/../../../modules/video_chroma/swscale.c:616
#4  0x179a26a3 in Filter (p_filter=0x15702b2c, p_pic=0x156fa408) at ../../extras/package/win32/../../../modules/video_chroma/swscale.c:667
#5  0x6a5c9d72 in FilterChainVideoFilter (f=0x15702b2c, p_pic=p_pic at entry=0x156fa408) at ../../extras/package/win32/../../../src/misc/filter_chain.c:387
#6  0x6a5ca779 in filter_chain_VideoFilter (p_chain=0x157020a0, p_pic=0x156fa408) at ../../extras/package/win32/../../../src/misc/filter_chain.c:405
#7  0x6a58c631 in vout_FilterDisplay (vd=0x157020a0, vd at entry=0x1576e994, picture=picture at entry=0x156fa408) at ../../extras/package/win32/../../../src/video_output/display.c:1105
#8  0x6a590ec9 in ThreadDisplayRenderPicture (is_forced=true, vout=0x15714bfc) at ../../extras/package/win32/../../../src/video_output/video_output.c:1036
#9  ThreadDisplayPicture (vout=vout at entry=0x15714bfc, deadline=deadline at entry=0x1803fe68) at ../../extras/package/win32/../../../src/video_output/video_output.c:1147
#10 0x6a591a5f in Thread (object=0x15714bfc) at ../../extras/package/win32/../../../src/video_output/video_output.c:1609
#11 0x6a5cefa8 in vlc_entry (p=0x1571b158) at ../../extras/package/win32/../../../src/win32/thread.c:472
#12 0x77c3a3b6 in msvcrt!_endthreadex () from C:\WINDOWS\system32\msvcrt.dll
#13 0x7c80b729 in KERNEL32!GetModuleFileNameA () from C:\WINDOWS\system32\kernel32.dll
#14 0x00000000 in ?? ()



- http://streams.videolan.org/issues/11351/Chrono%20Trigger%20-%20Ending%201.mov

(gdb) bt
#0  0x1bdd710b in planar2x_mmxext (
src=0x1de43ad0 "~\20027956\210", '7' <repeats 60 times>, "\201\201\201\201\200\200\200\200\200\200\200\200\177\20026767\210", '7' <repeats 60 times>, "\201\201\201\201\200\200\200\200\200\200\200\
200~\201?7\210669", '7' <repeats 32 times>..., dst=0x15ec7000 <error: Cannot access memory at address 0x15ec7000>, srcWidth=80, srcHeight=48, srcStride=80, dstStride=<optimized out>)
at libswscale/x86/rgb2rgb_template.c:1445
#1  0x1bdc489b in yvu9ToYv12Wrapper (c=0x157943c0, src=0x1c94f640, srcStride=0x1c94f660, srcSliceY=0, srcSliceH=192, dst=0x1c94f650, dstStride=0x1c94f670) at libswscale/swscale_unscaled.c:718
#2  0x1bdc96ce in sws_scale (c=c at entry=0x157943c0, srcSlice=srcSlice at entry=0x1c94f6c8, srcStride=srcStride at entry=0x1c94f6d8, srcSliceY=srcSliceY at entry=0, srcSliceH=srcSliceH at entry=192,
dst=dst at entry=0x1c94f6e8, dstStride=dstStride at entry=0x1c94f6f8) at libswscale/swscale_unscaled.c:1291
#3  0x1bdc1a04 in Convert (p_filter=p_filter at entry=0x15715054, ctx=0x157943c0, p_dst=p_dst at entry=0x15711d78, p_src=p_src at entry=0x156f5428, i_height=i_height at entry=192,
i_plane_count=i_plane_count at entry=3, b_swap_uvi=b_swap_uvi at entry=false, b_swap_uvo=false) at ../../extras/package/win32/../../../modules/video_chroma/swscale.c:616
#4  0x1bdc26a3 in Filter (p_filter=0x15715054, p_pic=0x156f5428) at ../../extras/package/win32/../../../modules/video_chroma/swscale.c:667
#5  0x6a5c9d72 in FilterChainVideoFilter (f=0x15715054, p_pic=p_pic at entry=0x156f5428) at ../../extras/package/win32/../../../src/misc/filter_chain.c:387
#6  0x6a5ca779 in filter_chain_VideoFilter (p_chain=0x15794008, p_pic=0x156f5428) at ../../extras/package/win32/../../../src/misc/filter_chain.c:405
#7  0x6a58c631 in vout_FilterDisplay (vd=0x15794008, vd at entry=0x156fdc6c, picture=picture at entry=0x156f5428) at ../../extras/package/win32/../../../src/video_output/display.c:1105
#8  0x6a590ec9 in ThreadDisplayRenderPicture (is_forced=false, vout=0x156aab84) at ../../extras/package/win32/../../../src/video_output/video_output.c:1036
#9  ThreadDisplayPicture (vout=vout at entry=0x156aab84, deadline=deadline at entry=0x1c94fe68) at ../../extras/package/win32/../../../src/video_output/video_output.c:1147
#10 0x6a591a5f in Thread (object=0x156aab84) at ../../extras/package/win32/../../../src/video_output/video_output.c:1609
#11 0x6a5cefa8 in vlc_entry (p=0x1567be00) at ../../extras/package/win32/../../../src/win32/thread.c:472
#12 0x77c3a3b6 in msvcrt!_endthreadex () from C:\WINDOWS\system32\msvcrt.dll
#13 0x7c80b729 in KERNEL32!GetModuleFileNameA () from C:\WINDOWS\system32\kernel32.dll
#14 0x00000000 in ?? ()


Especially modules\video_chroma\swscale.c:667 might be of interest.

Tell me if you need more information.


Regards
Domani Hannes