[vlc-devel] [vlc-commits] libvlc: refactor sfilter enabling/disabling

[Felix Paul Kühne]

Hello Rémi,

On Thu, Sep 4, 2014 at 11:42 AM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> Le 2014-09-04 12:28, Felix Paul Kühne a écrit :
>
>> It breaks the API behavior after a feature freeze (which was on Feb
>> 20) without coming up with a proper solution or workaround. Restarting
>> the adjust filter after changing any value is _not_ option, especially
>> given that libvlc client applications tend to show a slider for the
>> adjust values, so those can change multiple times _per second_, which
>> is not feasible when disabling and rebuilding the chain.
>
>
> I don't disagree that restarting the filter to change a parameter sucks (and
> if we wanted to do it that way, then why bother with all the filter
> callbacks?).

Exactly :-)

> But I don't really agree that fitler settings should always take immediate
> effects either. If you need to change more than one parameter, and you
> sometimes do, then applying the change straight away will result in a glitch
> at best, and a crash at worst (if the intermediate set of parameters is
> invalid).

I agree with your remark. A "apply settings" function for a filter
without restarting it might be neat. I'll keep that in mind for the
suggested discussion at VDD, since adding it now would break the API.

Thanks,

Felix