[vlc-devel] [PATCH 11/14] vout: lock picture pool when restarting vout thread

Felix Abecassis felix.abecassis at gmail.com
Thu Sep 11 22:01:18 CEST 2014

2014-09-10 17:50 GMT+02:00 Rémi Denis-Courmont <remi at remlab.net>:
> If you do that, the video output display will be destroyed, and the direct
> rendering picture pool alongside it. Then the decoder will crash when it tries
> to access a pending reference picture, or send an already locked picture for
> display.

Mmm, indeed.
I think we can also implement this with vout display events, like what
The vout display will be given the opportunity to acknowledge and
accept the new stereo format in the Control function: the vout should
return VLC_EGENERIC if it doesn't support the new stereo format and it
can request another format. In this case we should reset the vout
display and a conversion filter will automatically be added when
recreating the renderer. Of course this only works for vout that can
invalidate their pictures...

> There are a few video output display plugins that can keep their "old" picture
> buffers alive even after the display is destroyed. Even then, the decoder will
> still potentially crash in vout_ReleasePicture(). And in any case, the
> displaying any pending picture from the old format is likely to fail one way
> or another.
> --
> Rémi Denis-Courmont
> http://www.remlab.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

Félix Abecassis

More information about the vlc-devel mailing list