[vlc-devel] [PATCH 11/14] vout: lock picture pool when restarting vout thread

[Rémi Denis-Courmont]

Le jeudi 11 septembre 2014, 22:01:18 Felix Abecassis a écrit :
> I think we can also implement this with vout display events, like what
> we do for CHANGE_SOURCE_CROP and CHANGE_SOURCE_ASPECT.
(...)
> Of course this only works for vout that can invalidate their pictures...

Yes, changing a video format parameter dynamically independent of the decoder 
intrinsically requires that the picture buffers do not depend on the parameter.

There are only two ways to achieve that:
- the video output plugin can handle the dynamically parameter internally, or
- the video output plugin declares invalid pictures and effectively renders 
indirectly always.

I would find this performance regression unacceptable for even rotation or 
colour space. It is obviously totally unacceptable for a feature as 
confidential as stereo video.

-- 
Rémi Denis-Courmont
http://www.remlab.net/