[vlc-devel] [PATCH] [Android] Implement Scrobbling compatibility (#11904)
thomas at gllm.fr
Fri Apr 10 10:20:01 CEST 2015
On Thu, Apr 9, 2015, at 10:44, Jean-Baptiste Kempf wrote:
> On 09 Apr, Guillaume wrote :
> > Thanks for your insights. I made the following changes:
> > * If the media type isn't audio, the method is aborted.
> > * It's no longer using the Util methods, as Thomas recommended.
> > * The method doesn't require a Context argument anymore, since the service
> > itself is a Context.
> Why do you need to broadcast in so many places in the code? 8 times...
Because the code needs heavy refactoring.
Your patch is applied in master branch.
Thanks for your contribution.
> With my kindest regards,
> Jean-Baptiste Kempf
> http://www.jbkempf.com/ - +33 672 704 734
> Sent from my Electronic Device
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
More information about the vlc-devel