[vlc-devel] [PATCH] [Android] Implement Scrobbling compatibility (#11904)
h.guillaume at gmail.com
Fri Apr 10 10:32:10 CEST 2015
Awesome! To answer JB's question, I call the method whenever the
notification & the widget are updating.
Quick note: further testing revealed that mLibVLC.isPlaying() returned some
pretty odd results (pressing Next or Previous would randomly return True or
False). Let me know if you think I did something wrong.
On Fri, Apr 10, 2015 at 10:20 AM Thomas Guillem <thomas at gllm.fr> wrote:
> On Thu, Apr 9, 2015, at 10:44, Jean-Baptiste Kempf wrote:
> > On 09 Apr, Guillaume wrote :
> > > Thanks for your insights. I made the following changes:
> > >
> > > * If the media type isn't audio, the method is aborted.
> > > * It's no longer using the Util methods, as Thomas recommended.
> > > * The method doesn't require a Context argument anymore, since the
> > > itself is a Context.
> > Good.
> > Why do you need to broadcast in so many places in the code? 8 times...
> Because the code needs heavy refactoring.
> Your patch is applied in master branch.
> Thanks for your contribution.
> > With my kindest regards,
> > --
> > Jean-Baptiste Kempf
> > http://www.jbkempf.com/ - +33 672 704 734
> > Sent from my Electronic Device
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the vlc-devel