[vlc-devel] [PATCH] input: add vlc_alternatives.h

Rémi Denis-Courmont remi at remlab.net
Wed Aug 5 10:43:59 CEST 2015


Le 2015-08-04 20:57, Francois Cartegnie a écrit :
> This is a tentative to add some adaptative content 
> selection/notifications.

You don't explain why you need yet another layer. We already have 
groups of ES. AFAIK, the only things that they cannot deal with are:
- ES in more than one group,
- relation between ES of the same type within a group.

To introduce yet another dimension to ES selection will break all UIs 
and all LibVLC apps. It would need a pretty damn good reason why ES 
groups fundamentally cannot solve the problem, and why the new solution 
actually solves it. I see neither of those explanations here.

> There's some missing locking that should occur when updating
> input thread private data. Not even sure the control() way is the
> correct one.

That's not acceptable. We have threaded demuxers and (as per HAM 
discussion) plans to move demuxers to their own threads. Thus the input 
thread and the ES output have to be thread-safe to the extent that the 
demuxers are concerned.

Rémi Denis-Courmont

More information about the vlc-devel mailing list