[vlc-devel] [PATCH] input: add vlc_alternatives.h

[Francois Cartegnie]

Le 05/08/2015 10:43, Rémi Denis-Courmont a écrit :
>    Hello,
> 
> Le 2015-08-04 20:57, Francois Cartegnie a écrit :
>> This is a tentative to add some adaptative content
>> selection/notifications.
> 
> You don't explain why you need yet another layer. We already have groups
> of ES. AFAIK, the only things that they cannot deal with are:
> - ES in more than one group,
> - relation between ES of the same type within a group.

Alternatives have same relationship with es as a chaptered ts.
You don't know which es and group will be created before switching to
chapter, as depending on bandwith, there could be different codecs and
less/more es.

The patch is only to provide a way to forward alternatives to UI so the
user can pick (override auto or fixed bandwidth logic) and get feedback
about current alternative/bandwith.

This has nothing to do with content alternatives which are handled by
es/group selection in adaptative.

>> There's some missing locking that should occur when updating
>> input thread private data. Not even sure the control() way is the
>> correct one.
> 
> That's not acceptable. We have threaded demuxers and (as per HAM
> discussion) plans to move demuxers to their own threads. Thus the input
> thread and the ES output have to be thread-safe to the extent that the
> demuxers are concerned.

I did mention something was "missing" and that wasn't probably correctly
done. As there's no lock at input level, I'm unsure what to do.
(controls a real no go ? update flags would work ?)

Francois