[vlc-devel] [PATCH] direct3d9: replace ID3DXBuffer (mingw) with ID3D10Blob

[Steve Lhomme]

On Mon, Aug 17, 2015 at 3:01 PM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
> On 17 Aug, Steve Lhomme wrote :
>> -            LPD3DXBUFFER *ppShader,
>> -            LPD3DXBUFFER *ppErrorMsgs,
>> +            ID3D10Blob **ppShader,
>> +            ID3D10Blob **ppErrorMsgs,
>
> https://msdn.microsoft.com/en-us/library/windows/desktop/bb205753%28v=vs.85%29.aspx
> D3dx9.lib
>
> https://msdn.microsoft.com/en-us/library/windows/desktop/bb173507%28v=vs.85%29.aspx
> D3D10.lib
>
> This change requires Dx10, therefore Vista.
> I'm not sure it's a good idea.

No, it's just COM calls. I just changed the old mingw-specific calls
to the proper Windows API entries. It builds fine here with mingw
without d3d10.lib/a at all.

Strangely the Win8/8.1 and 10 SDKs don't ship with D3DX9Mesh.h or
D3DX9Shader.h. You need to install an older SDK to have them. d3d9.h
is still there.

But I agree, that may cause problems because we look for
"D3DXCompileShader" from the d3dx9* DLL (whichever variant is found
first). Rather than "D3D10CompileShader" from a more recent DLL.

So we should just keep the code as is for now. Maybe supporting both
in the future.


> With my kindest regards,
>
> --
> Jean-Baptiste Kempf
> http://www.jbkempf.com/ - +33 672 704 734
> Sent from my Electronic Device
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel