[vlc-devel] [PATCH] v4l2: Fix SetupFormat for CONTINUOUS framesize

Ricardo Ribalda Delgado ricardo.ribalda at gmail.com
Fri Aug 21 17:21:25 CEST 2015


It is a bit embarrassing, but in this case, the broken driver is mine
:). I already fixed the bug on the driver.

I just wanted to make sure that future developers did not hit the same
wall as me.


On Fri, Aug 21, 2015 at 4:57 PM, Devin Heitmueller
<dheitmueller at kernellabs.com> wrote:
> On Fri, Aug 21, 2015 at 10:35 AM, Ricardo Ribalda Delgado
> <ricardo.ribalda at gmail.com> wrote:
>> Some devices with CONTINUOUS framesize can set step_width or step_height
>> to zero, entering an endless loop.
> Ugh.  I'm not against this patch, but which device(s) are we talking
> about, and have you complained on the linux-media mailing list?  This
> is likely something Hans can tweak in the framework to make sure a
> driver *never* returns a stepsize of zero (i.e. make the v4l2
> framework force the value to 1 if the driver says zero before
> returning the ioctl call to userland.
> Devin
> --
> Devin J. Heitmueller - Kernel Labs
> http://www.kernellabs.com
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

Ricardo Ribalda

More information about the vlc-devel mailing list