[vlc-devel] [PATCH] libvlc: replace existing title menu bool with int bit mask

Francois Cartegnie fcvlcdev at free.fr
Fri Dec 18 16:28:11 CET 2015


Le 18/12/2015 15:29, Felix Paul Kühne a écrit :

> -    bool b_menu; /**< info if item was recognized as a menu by the demuxer */
> +    int i_flags; /**< info if item was recognized as a menu, interactive or plain content by the demuxer */

Sign makes no sense, except if you want to raise warnings matching with
0x80000000

>  /* input_title_t.i_flags field */
> -#define INPUT_TITLE_MENU         0x0001   /* Menu title */
> -#define INPUT_TITLE_INTERACTIVE  0x0002   /* Interactive title. Playback position has no meaning. */
> +#define INPUT_TITLE_MENU         0x01   /* Menu title */
> +#define INPUT_TITLE_INTERACTIVE  0x02   /* Interactive title. Playback position has no meaning. */

Needs no change.
If you really want no confusion for later adds, do comment or use (1 <<
0) and (1 << 1)

Francois



More information about the vlc-devel mailing list