[vlc-devel] [PATCH] libvlc: replace existing title menu bool with int bit mask
Felix Paul Kühne
fkuehne at videolan.org
Fri Dec 18 16:38:02 CET 2015
> On 18 Dec 2015, at 16:28, Francois Cartegnie <fcvlcdev at free.fr> wrote:
> Le 18/12/2015 15:29, Felix Paul Kühne a écrit :
>> - bool b_menu; /**< info if item was recognized as a menu by the demuxer */
>> + int i_flags; /**< info if item was recognized as a menu, interactive or plain content by the demuxer */
> Sign makes no sense, except if you want to raise warnings matching with
Indeed. This would also match the i_flags for libvlc_media, which is unsigned also.
>> /* input_title_t.i_flags field */
>> -#define INPUT_TITLE_MENU 0x0001 /* Menu title */
>> -#define INPUT_TITLE_INTERACTIVE 0x0002 /* Interactive title. Playback position has no meaning. */
>> +#define INPUT_TITLE_MENU 0x01 /* Menu title */
>> +#define INPUT_TITLE_INTERACTIVE 0x02 /* Interactive title. Playback position has no meaning. */
> Needs no change.
> If you really want no confusion for later adds, do comment or use (1 <<
> 0) and (1 << 1)
In my previous submission, Rémi asked for smaller numbers, so I went for smaller numbers. I can split in 2 commits if desired.
More information about the vlc-devel