[vlc-devel] [PATCH] libvlc: replace existing title menu bool with int bit mask

[Hugo Beauzée-Luyssen]

On 12/18/2015 04:38 PM, Felix Paul Kühne wrote:
>
>> On 18 Dec 2015, at 16:28, Francois Cartegnie <fcvlcdev at free.fr> wrote:
>>
>> Le 18/12/2015 15:29, Felix Paul Kühne a écrit :
>>
>>> -    bool b_menu; /**< info if item was recognized as a menu by the demuxer */
>>> +    int i_flags; /**< info if item was recognized as a menu, interactive or plain content by the demuxer */
>>
>> Sign makes no sense, except if you want to raise warnings matching with
>> 0x80000000
>
> Indeed. This would also match the i_flags for libvlc_media, which is unsigned also.
>

If you want to store the masks as an enum you won't be able to use 
values above 0x7FFFFFFF since they have to fit in a signed int, so I'd 
argue signed makes sense here, provided the masks are exposed as enum 
members.

Regards,