[vlc-devel] [PATCH] Fix folder opening regression

Rémi Denis-Courmont remi at remlab.net
Wed Feb 11 16:25:51 CET 2015

Le 2015-02-11 18:11, Thomas Guillem a écrit :
> Don't always parse for sub items from input_Preparse (used by 
> playlist
> preparser).
> Add libvlc_PreparseRequest that extends libvlc_MetaRequest with a new
> b_parse_sub_items argument. This new function is used by lib/media.c
> that need
> to parse sub items.
> This fixes a regression brought by 
> 4bc33dbc16a4dc749c006a58ddb8701d1a146ec9
> Close #13850 #13872

This is not fixing anything AFAICT. This patch hides the regression 
*and* the corresponding new feature behind an arbitrary predicate. 
Consequently, on the one hand, LibVLC is still broken/regressing. On the 
other hand, VLC looses the new feature and will regress again if, or 
rather when, someone reintroduces the feature of preparsing directories.

Also inserting arbitrary inconsistencies between VLC and LibVLC is 
probably not a good idea - considering how little testing LibVLC gets.

Rémi Denis-Courmont

More information about the vlc-devel mailing list