[vlc-devel] [PATCH] Fix folder opening regression

[Thomas Guillem]

On Wed, Feb 11, 2015, at 16:25, Rémi Denis-Courmont wrote:
> Le 2015-02-11 18:11, Thomas Guillem a écrit :
> > Don't always parse for sub items from input_Preparse (used by 
> > playlist
> > preparser).
> >
> > Add libvlc_PreparseRequest that extends libvlc_MetaRequest with a new
> > b_parse_sub_items argument. This new function is used by lib/media.c
> > that need
> > to parse sub items.
> >
> > This fixes a regression brought by 
> > 4bc33dbc16a4dc749c006a58ddb8701d1a146ec9
> > Close #13850 #13872
> 
> This is not fixing anything AFAICT. This patch hides the regression 
> *and* the corresponding new feature behind an arbitrary predicate. 
> Consequently, on the one hand, LibVLC is still broken/regressing. On the 
> other hand, VLC looses the new feature and will regress again if, or 
> rather when, someone reintroduces the feature of preparsing directories.
> 
> Also inserting arbitrary inconsistencies between VLC and LibVLC is 
> probably not a good idea - considering how little testing LibVLC gets.

OK I agree,

For #13872:
My idea is to remove recursive handling in access/fs.c and
access/directory.c and handle it in playlist preparser. So I have to
move the --recursive option from access/fs to libvlc.

For #13850: still investigating.

> 
> -- 
> Rémi Denis-Courmont
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel