[vlc-devel] [PATCH] MKV: MKV_DEBUG is set to 0 or 1, not tested for defined()

Jean-Baptiste Kempf jb at videolan.org
Sat Feb 28 11:00:29 CET 2015

On 27 Feb, Steve Lhomme wrote :
> -#ifdef MKV_DEBUG
> +#if MKV_DEBUG

I would prefer that you do it the other way around, aka, use ifdef, and
change the ones using if to ifdef.
It's what we use in other modules and is easier to pass through command
line or script compilation

With my kindest regards,

Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device

More information about the vlc-devel mailing list