[vlc-devel] [PATCH 1/4] Fix issue with jni_ConfigureSurface return value. Only check for configure flag if return is equal to 0. Return value of -1 is ignored.

Paulo Vitor Magacho da Silva pvmagacho at gmail.com
Wed Jan 21 16:50:22 CET 2015


Actually not. -1 means to ignore jni_ConfigureSurface as there is nothing
to be done.
An error is determined when the return value is 0 and configured flag is
false.
Thanks

2015-01-21 13:41 GMT-02:00 Jean-Baptiste Kempf <jb at videolan.org>:

> On 11 Dec, Paulo Vitor Magacho da Silva wrote :
> > ---
> >  modules/video_output/android/surface.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Why?
> This does not make sense to me. If jni_ConfigureSurface returns -1, then
> something is wrong, and we should return EGENERIC.
>
> With my kindest regards,
>
> --
> Jean-Baptiste Kempf
> http://www.jbkempf.com/ - +33 672 704 734
> Sent from my Electronic Device
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20150121/5d0bbe51/attachment.html>


More information about the vlc-devel mailing list