[vlc-devel] [RFC] libvlc browsing: questions about new features

[Rémi Denis-Courmont]

Le lundi 26 janvier 2015, 16:24:25 Thomas Guillem a écrit :
> On Mon, Jan 26, 2015, at 16:18, Rémi Denis-Courmont wrote:
> > Le lundi 26 janvier 2015, 15:02:40 Thomas Guillem a écrit :
> > > > I fail to see why the application would need, and should be granted
> > > > access to those. They should not even be in the input items to begin
> > > > with, otherwise they might end up in clear text in playlist files.
> > > 
> > > I'll need to a way to save/restore samba password/login set by VLC via
> > > dialog.
> > 
> > The credentials won´t magically get from the password dialog to the
> > "right"
> > input item (if any). That just makes no sense.
> 
> I think it's already the case, in dsm/access.c
> 
> i_ret = asprintf( &psz_option, "smb-pwd=%s", p_sys->creds.password );
> if( i_ret == -1 )
>     return VLC_ENOMEM;
> input_item_AddOption( p_item, psz_option, VLC_INPUT_OPTION_TRUSTED );
> free( psz_option );

Leaving aside the fact that the code fails miserably if the password contains 
some inconvenient characters, where do you get the item from? You know 
browsing is the exception, not the rule...

-- 
Rémi Denis-Courmont
http://www.remlab.net/