[vlc-devel] [PATCH] win32/thread: avoid waking up every 50ms to see if the thread is canceled

[Rémi Denis-Courmont]

Le 2015-07-20 16:44, Steve Lhomme a écrit :
>> What if count is not one?
>> What is "handle != NULL" for?
>
> `ret` is initialized to WAIT_FAILED so at the end of the `else` it
> will consider there's an invalid call and crash.

>> What if poll() is used?
>
> I don't know what poll does.
>
>> More importantly, this fix is likely in vain given that 
>> vlc_cond_broadcast()
>> is broken on Windows (not only WinRT).
>
> Well, it works better than the old patch we had in place which was
> deadlocking.

So you say. Looks much worse to me.

-- 
Rémi Denis-Courmont
http://www.remlab.net/