[vlc-devel] [PATCH] win32/thread: avoid waking up every 50ms to see if the thread is canceled
robux4 at videolabs.io
Mon Jul 20 15:57:10 CEST 2015
On Mon, Jul 20, 2015 at 3:53 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> Le 2015-07-20 16:44, Steve Lhomme a écrit :
>>> What if count is not one?
>>> What is "handle != NULL" for?
>> `ret` is initialized to WAIT_FAILED so at the end of the `else` it
>> will consider there's an invalid call and crash.
>>> What if poll() is used?
>> I don't know what poll does.
>>> More importantly, this fix is likely in vain given that
>>> is broken on Windows (not only WinRT).
>> Well, it works better than the old patch we had in place which was
> So you say. Looks much worse to me.
This is what I'm talking about that was deadlocking.
We still want to about this 50 ms polling.
> Rémi Denis-Courmont
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
More information about the vlc-devel