[vlc-devel] [vlc-commits] macosx: fix runtime exception when loading the simple prefs with the Punjabi locale active (closes #15106)

[David Fuhrmann]

On 26. Juli 2015 15:31:52 MESZ, git at videolan.org wrote:
>vlc | branch: master | Felix Paul Kühne <fkuehne at videolan.org> | Sun
>Jul 26 15:29:56 2015 +0200| [342acefac1f6122ccbd28e1b4392ade632d8e80e]
>| committer: Felix Paul Kühne
>
>macosx: fix runtime exception when loading the simple prefs with the
>Punjabi locale active (closes #15106)
>
>>
>http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=342acefac1f6122ccbd28e1b4392ade632d8e80e
>---
>
>modules/gui/macosx/simple_prefs.m |   31
>+++++++++++++++++++++++--------
> 1 file changed, 23 insertions(+), 8 deletions(-)
>
>diff --git a/modules/gui/macosx/simple_prefs.m
>b/modules/gui/macosx/simple_prefs.m
>index 8543e7a..4bb36bb 100644
>--- a/modules/gui/macosx/simple_prefs.m
>+++ b/modules/gui/macosx/simple_prefs.m
>@@ -704,15 +704,30 @@ static inline char *
>__config_GetLabel(vlc_object_t *p_this, const char *psz_nam
> 
>[self setupButton:_input_mkv_preload_dirCheckbox forBoolValue:
>"mkv-preload-local-dir"];
> 
>+    /* do not trust translators to do the correct thing,
>+     * so re-build the menu in an unorthodox way (#15106) */

Hi Felix,

I would prefer if we avoid making such commits at all if you feel like marking it as a hack already before commiting.

This text helps not much IMO (they might be other places where we use translated text through same way).

And I am sure they is a less non-orthodox way to fix the issue as well.

Best regards,
David