[vlc-devel] [PATCH] MKV: don't update the playback PTS from unused tracks

Steve Lhomme robux4 at gmail.com
Tue Mar 3 10:02:53 CET 2015

On 02/03/2015 12:23, Steve Lhomme wrote:
> On 02/03/2015 12:11, Rémi Denis-Courmont wrote:
>> Le 2015-03-02 14:02, Steve Lhomme a écrit :
>>> Fixes #11847
>>> This file has bad interleaving and shows the progress of broken
>>> tracks that are not in use.
>>> With this patch we only show the progress for the track(s) in use
>> In my understanding, the demuxer should only use the ES state as an
>> optimization. This is especially useful for filtering with RTSP, DVB or
>> MMS.
>> Having the timeline depend on the selected track seems like a terrible
>> idea for somewhat obvious reasons.
> Yes, but this is a global value that's kept during playback. Right now
> it can even go backward in time if a packet with an old timestamp is
> encountered. And that's the value to report where we are during playback.

It's also weird that the playback time displayed seem to come from the 
demuxer. There can be a lot of frame buffering between the demuxer and 
the renderer.

Hopefully the result of DEMUX_GET_TIME is not used for things more 
precise like gapless playback. And if that's not the case, maybe we can 
use another source for the displayed playback time that's more accurate ?


More information about the vlc-devel mailing list