[vlc-devel] [PATCH] mmdevice: don't pretend to be DirectSound with a higher capability

[Steve Lhomme]

On Tue, Mar 17, 2015 at 12:52 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> Looks nonsensical to me. This is not pretending, this *is* Dsound. I fail to
> see a "regression".

>From https://trac.videolan.org/vlc/ticket/14186, the first audio track
doesn't play at all with the current master. With my patch it does.

There are still other tracks that don't play with "mmdevice" and that
play fine with "directsound". So I doubt the two are equal.

It's a regression as 2.2.0 plays the first track fine. The 6th track
doesn't play though.

--audio-track-id 6 --aout=directsound [CCCP]_Mega_Audio_Test.mkv < works
--audio-track-id 6 --aout=mmdevice [CCCP]_Mega_Audio_Test.mkv <
stutters even on 2.2

> --
> Rémi Denis-Courmont
> Sent from my NVIDIA Tegra-powered device
>
> ----- Reply message -----
> De : "Steve Lhomme" <robUx4 at videolabs.io>
> Pour : <vlc-devel at videolan.org>
> Objet : [vlc-devel] [PATCH] mmdevice: don't pretend to be DirectSound with a
> higher capability
> Date : mar., mars 17, 2015 13:03
>
> Fixes #14186
>
> But introduced in 491578ce67ecc542c90bf3940fbdb3f90a2b5058
> ---
>  modules/audio_output/mmdevice.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/modules/audio_output/mmdevice.c
> b/modules/audio_output/mmdevice.c
> index d9d3573..d6cce9e 100644
> --- a/modules/audio_output/mmdevice.c
> +++ b/modules/audio_output/mmdevice.c
> @@ -1212,6 +1212,6 @@ vlc_module_begin()
>      set_capability("audio output", 150)
>      set_category(CAT_AUDIO)
>      set_subcategory(SUBCAT_AUDIO_AOUT)
> -    add_shortcut("wasapi", "directsound")
> +    add_shortcut("wasapi")
>      set_callbacks(Open, Close)
>  vlc_module_end()
> --
> 2.3.2
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>