[vlc-devel] [PATCH] mmdevice: don't pretend to be DirectSound with a higher capability

[Rémi Denis-Courmont]

Le 2015-03-17 15:20, Steve Lhomme a écrit :
> On Tue, Mar 17, 2015 at 12:52 PM, Rémi Denis-Courmont
> <remi at remlab.net> wrote:
>> Looks nonsensical to me. This is not pretending, this *is* Dsound. I 
>> fail to
>> see a "regression".
>
> From https://trac.videolan.org/vlc/ticket/14186, the first audio 
> track
> doesn't play at all with the current master.

Your patch cannot possibly fix a would-be vlc.git playback regression, 
since it has no effects with default settings. At best, it will hide the 
bug in non-default settings, and leave it open with default settings. 
Great. Not.

> With my patch it does.

With your patch, audio session management is disabled and broken if 
DirectSound is selected as output (except on Windows XP/2003 where it 
has no effects).

-- 
Rémi Denis-Courmont