[vlc-devel] [PATCH 1/1] freetype: handle non-English family and style names in Windows

[Jean-Baptiste Kempf]

On 19 Nov, Salah-Eddin Shaban wrote :
> On Thu, Nov 19, 2015 at 8:08 PM, Salah-Eddin Shaban
> <salshaaban at gmail.com> wrote:
> > On Wed, Nov 18, 2015 at 9:47 PM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
> >> On 18 Nov, Salah-Eddin Shaban wrote :
> >>> Not really.
> >>> The characters in p_name are big endian and _tcsncpy won't work with
> >>> little endian systems.
> >>
> >> Wut? That's weird.
> >>
> >>> So the U16_AT is necessary.
> >>
> >> So we are assuming that we are in UCS-2? Because IIRC UTF-16 is also
> >> variable length above 2-bytes, no?
> >>
> >
> > The spec says: "UGL character set with Unicode indexing scheme"
> > So it's UTF-16.
> >
> > Although I'm not sure if the UGL character set has any characters that
> > require more than 2 bytes.
> >
> 
> Even if it does, though, it will be 2 16-bit code units.
> So I don't see any problem here.

Well, the stringlen is in characters, not in 16-bit code units, no?

UTF-16 can take 4 characters, no?

Hence my question...
Maybe I'm totally missing everything.

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device