[vlc-devel] [PATCH 1/1] freetype: handle non-English family and style names in Windows

Salah-Eddin Shaban salshaaban at gmail.com
Thu Nov 19 20:46:27 CET 2015


On Thu, Nov 19, 2015 at 9:09 PM, Jean-Baptiste Kempf <jb at videolan.org> wrote:

>> > The spec says: "UGL character set with Unicode indexing scheme"
>> > So it's UTF-16.
>> >
>> > Although I'm not sure if the UGL character set has any characters that
>> > require more than 2 bytes.
>> >
>>
>> Even if it does, though, it will be 2 16-bit code units.
>> So I don't see any problem here.
>
> Well, the stringlen is in characters, not in 16-bit code units, no?
>
> UTF-16 can take 4 characters, no?
>

i_name_length is in bytes.
Divided by 2 it produces the number of wchar_t's (the number of 16-bit
code units) which is i_length_in_wchars.

We are reading 2 bytes at a time from p_name (1 wchar_t at a time)

UTF-16 can take 4 bytes. In this case 2 wchar_t's will produce only
one Unicode codepoint.

I think everything is correct.

> Hence my question...
> Maybe I'm totally missing everything.
>
> With my kindest regards,
>
> --
> Jean-Baptiste Kempf
> http://www.jbkempf.com/ - +33 672 704 734
> Sent from my Electronic Device
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list