[vlc-devel] [RFC PATCH] VLC keystore API

[Steve Lhomme]

On Mon, Nov 23, 2015 at 6:10 AM, Thomas Guillem <thomas at gllm.fr> wrote:
> Here is a first draft of the vlc keystore api: vlc_keystore.h (I'm still
> working on module implementation and integration).
>
> I have some questions:
>
> 1/ Should we create a new keystore module each time a module
> (access/demux/other?) wants to access it ? I think it should be a singleton
> owned by libvlc, by the input thread or by the playlist to avoid too many
> connect/disconnect when playing a http playlist for example.

I don't see how it would affect reconnection. Because it would be
slower to load a module than calling the one already in memory ?

> 2/ It is possible to store more than one user/password for one
> protocol/server/port, that's why vlc_keystore_dict_find() return a list of
> entries.
> Therefore, If a default user is specified (in arguments or url),
> vlc_keystore_dict_find() will return only the entry matching with the user. But
> if no user are specified and if vlc_keystore_dict_find() return more than one
> entries, we can't know which user/password we should use. What should we do in
> that case ? Try only the first one and pop up a dialog if it fails ? (we can't
> test all user/password because the server could ban us)

Use the last used one ?

> Thomas Guillem (1):
>   add vlc_keystore API
>
>  include/vlc_keystore.h | 202 +++++++++++++++++++++++++++++++++++++++++++++++++
>  src/Makefile.am        |   2 +
>  src/misc/keystore.c    | 162 +++++++++++++++++++++++++++++++++++++++
>  3 files changed, 366 insertions(+)
>  create mode 100644 include/vlc_keystore.h
>  create mode 100644 src/misc/keystore.c
>
> --
> 2.1.4
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel