[vlc-devel] [RFC PATCH] VLC keystore API

[Rémi Denis-Courmont]

Le 2015-11-23 17:10, Thomas Guillem a écrit :
> Here is a first draft of the vlc keystore api: vlc_keystore.h (I'm 
> still
> working on module implementation and integration).
>
> I have some questions:
>
> 1/ Should we create a new keystore module each time a module
> (access/demux/other?) wants to access it ?

I think so. Otherwise, you have to deal with a lot of ugliness and 
reentrancy issues.

> I think it should be a singleton
> owned by libvlc, by the input thread or by the playlist to avoid too 
> many
> connect/disconnect when playing a http playlist for example.

The cost of loading the plug-in is once per process or per instance 
anyway. The cost of module probing could be vastly reduced by careful 
optimization, and the keystore is not the most performance sensitive 
module to begin with.

> 2/ It is possible to store more than one user/password for one
> protocol/server/port, that's why vlc_keystore_dict_find() return a 
> list of
> entries.

Ultimately, this boils down to the login dialog. It can only have one 
username and password at a time. If there are more than one set of 
credentials, it should either be kept between the dialog provider and 
the key store, or fully hidden within the key store. The requesting code 
can probably not deal with multiple credentials in any reasonable ways.

-- 
Rémi Denis-Courmont
http://www.remlab.net/