[vlc-devel] [PATCH 1/3] poll: keep already signaled events that are not used between calls

Rémi Denis-Courmont remi at remlab.net
Fri Nov 27 14:47:25 CET 2015

Le 2015-11-27 15:52, Steve Lhomme a écrit :
> If by "this patch makes no sense" you mean that it won't work when 
> the
> `struct polld` is not reused between calls, I agree. Looking at the
> code it seems to be the general case.

The point is that I am fed up using 30-90 minutes of my free time 
almost every day in code reviews, especially when issues could be easily 
found by
- running the test suite,
- flame testing,
- memory and UB instrumentation,
- glancing at the relevant documentation,
- grepping the source code,  and/or
- minding recent mailing list discussions.

I fully expect to have those issue during my working hours with a 
would-be intern at my own company. I don't expect nor want to deal with 
those issues on my free time for senior commercial developers.

Rémi Denis-Courmont

More information about the vlc-devel mailing list