[vlc-devel] [PATCH 1/3] poll: keep already signaled events that are not used between calls

Jean-Baptiste Kempf jb at videolan.org
Fri Nov 27 15:34:53 CET 2015


On 27 Nov, Rémi Denis-Courmont wrote :
> The point is that I am fed up using 30-90 minutes of my free time almost
> every day in code reviews, especially when issues could be easily found by
> - running the test suite,
> - flame testing,
> - memory and UB instrumentation,
> - glancing at the relevant documentation,
> - grepping the source code,  and/or
> - minding recent mailing list discussions.
> I fully expect to have those issue during my working hours with a would-be
> intern at my own company. I don't expect nor want to deal with those issues
> on my free time for senior commercial developers.

A few remarks:
 - I've already offered you to pay you for review time; I renew this

 - Everyone makes mistakes and does not always test sufficiently, and
   you are also guilty of this. An example is the decoder seeking that
   you broke and that took almost 2 weeks of Thomas' time to fix and is
   still not correctly fixed.

   It happens. It's not cool, but that's life.
   I wish VLC's core was way better, but Fenrir is gone and the oldies
   left with way too many hacks.
   Your work has been amazing to clean those hacks (do not believe we
   underestimate this work), but yes, sometimes it breaks... And noone
   complains when they try to fix the regressions, even if it takes
   time, or seems not perfect.

 - We're not always as good technically as you are, and some things with
   network or threads are still hard to understand. (And if you combine
   that with borken OSes like Windows, OS X or Android, that's even worse).
   So helpful reviews (shorter but more precise maybe?) help a lot so we
   can get there...

   Having someone proficient in VLC takes between 12 months to 18
   months, if we look at Thomas and François, but we need more people
   skilled in the core. I know it's frustrating sometimes.
With my kindest regards,

Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device

More information about the vlc-devel mailing list