[vlc-devel] [PATCH v2 4/9] equalizer: Add support for extra sets of ISO bands

[Jean-Baptiste Kempf]

On 28 Nov, Ronald Wright wrote :
> +#define EQZ_INCLUDE_MATH_ROUTINES 1

Why this define?

> +         "Don't use presets, but manually specified bands. You need to "      \
> +         "provide 10, 15, or 31 values between -20dB and 20dB, separated by " \
> +         "spaces (e.g. \"0 2 4 2 0 -2 -4 -2 0 2\"). You may optionally "      \
> +         "append a parameter \"v\" (valid for 10 values only) or \"i\" "      \
> +         "(valid for 10, 15, and 31 values) to help VLC differentiate "       \
> +         "between VLC bands and ISO bands, respectively. The band values "    \
> +         "are interpolated if the number of bands suggested by the "          \
> +         "specified string is valid (i.e. 10, 15, or 31) and differs from "   \
> +         "the current number of bands." )

This is wayyy too long.

>  #define VLC_BANDS_TEXT N_( "Use VLC frequency bands" )
>  #define VLC_BANDS_LONGTEXT N_( \
>           "Use the VLC frequency bands. Otherwise, use the ISO Standard " \
> -         "frequency bands." )
> +         "frequency bands. This option is valid for 10 bands only." )

This is weird tbh.

> +#define BANDS_COUNT_TEXT N_( "Number of bands" )
> +#define BANDS_COUNT_LONGTEXT N_( \
> +         "Select the number of bands to use for the equalizer." )

I'd say you need a selector with a few choices.

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device