[vlc-devel] [PATCH v2 4/9] equalizer: Add support for extra sets of ISO bands
logiconcepts819 at gmail.com
Sun Nov 29 00:41:41 CET 2015
On 11/28/2015 05:26 PM, Jean-Baptiste Kempf wrote:
> Why this define?
The EQZ_INCLUDE_MATH_ROUTINES define is needed because I wanted to make
it optional to include math.h before including equalizer_presets.h when
EqzGetTrueFrequency(), which requires math.h, is not used. At the same
time, I wanted to keep the EqzGetTrueFrequency() function definition
inline to ensure good performance, so to make sure a compiler error
doesn't occur, the function definition needs to be masked out when it's
not required. Here, the equalizer.c file is using EqzGetTrueFrequency(),
which requires EQZ_INCLUDE_MATH_ROUTINES to be defined.
>> + "Don't use presets, but manually specified bands. You need to " \
>> + "provide 10, 15, or 31 values between -20dB and 20dB, separated by " \
>> + "spaces (e.g. \"0 2 4 2 0 -2 -4 -2 0 2\"). You may optionally " \
>> + "append a parameter \"v\" (valid for 10 values only) or \"i\" " \
>> + "(valid for 10, 15, and 31 values) to help VLC differentiate " \
>> + "between VLC bands and ISO bands, respectively. The band values " \
>> + "are interpolated if the number of bands suggested by the " \
>> + "specified string is valid (i.e. 10, 15, or 31) and differs from " \
>> + "the current number of bands." )
> This is wayyy too long.
>> #define VLC_BANDS_TEXT N_( "Use VLC frequency bands" )
>> #define VLC_BANDS_LONGTEXT N_( \
>> "Use the VLC frequency bands. Otherwise, use the ISO Standard " \
>> - "frequency bands." )
>> + "frequency bands. This option is valid for 10 bands only." )
> This is weird tbh.
Why weird? Aren't VLC frequency bands defined for 10 bands only?
> I'd say you need a selector with a few choices.
What's wrong with the selector that's already present? It allows the
user to select from 10, 15, or 31 bands.
More information about the vlc-devel