[vlc-devel] [PATCH v3 05/10] equalizer: Add support for extra sets of ISO bands

[Jean-Baptiste Kempf]

On 29 Nov, Ronald Wright wrote :
> -#define BANDS_TEXT N_( "Bands gain")
> +#define BANDS_TEXT N_( "Bands gain" )

Unnecessary change.

>  #define BANDS_LONGTEXT N_( \
> -         "Don't use presets, but manually specified bands. You need to " \
> -         "provide 10 values between -20dB and 20dB, separated by spaces, " \
> -         "e.g. \"0 2 4 2 0 -2 -4 -2 0 2\"." )
> -
> -#define VLC_BANDS_TEXT N_( "Use VLC frequency bands" )
> +         "Don't use presets, but manually specified bands. You need to "      \
> +         "provide 10, 15, or 31 values between -20dB and 20dB, separated by " \
> +         "spaces (e.g. \"0 2 4 2 0 -2 -4 -2 0 2\"). You may optionally "      \
> +         "append a parameter \"v\" (valid for 10 values only) or \"i\" "      \
> +         "(valid for 10, 15, and 31 values) to help VLC differentiate "       \
> +         "between VLC bands and ISO bands, respectively." )

No way our translators can translate that.

> +#define VLC_BANDS_TEXT N_( "Use VLC frequency bands (deprecated)" )
>  #define VLC_BANDS_LONGTEXT N_( \
> -         "Use the VLC frequency bands. Otherwise, use the ISO Standard " \
> -         "frequency bands." )
> +         "This option is not used anymore; select \"10-band VLC equalizer\" " \
> +         "as the equalizer type if you wish to use VLC frequency bands." )

Sorry, but no. If it's deprecated, mark it as deprecated.

> +#define VLC_EQZTYPE_TEXT N_( "Equalizer type" )
> +#define VLC_EQZTYPE_LONGTEXT N_( \
> +         "Select the equalizer type to use. Options include the 10-band VLC " \
> +         "equalizer and the 10-, 15-, and 31-band ISO equalizers." )
>  
>  #define TWOPASS_TEXT N_( "Two pass" )
>  #define TWOPASS_LONGTEXT N_( "Filter the audio twice. This provides a more "  \
> @@ -92,6 +99,9 @@ vlc_module_begin ()
>                TWOPASS_LONGTEXT, true )
>      add_bool( "equalizer-vlcfreqs", true, VLC_BANDS_TEXT,
>                VLC_BANDS_LONGTEXT, true )
> +    add_string( "equalizer-type", "vlc10", VLC_EQZTYPE_TEXT,
> +                VLC_EQZTYPE_LONGTEXT, true )
> +        change_string_list( eqz_types, eqz_types_text )

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device