[vlc-devel] [PATCH v3 05/10] equalizer: Add support for extra sets of ISO bands

[Ron Wright]

On 11/30/2015 02:46 AM, Jean-Baptiste Kempf wrote:
>>   #define BANDS_LONGTEXT N_( \
>> -         "Don't use presets, but manually specified bands. You need to " \
>> -         "provide 10 values between -20dB and 20dB, separated by spaces, " \
>> -         "e.g. \"0 2 4 2 0 -2 -4 -2 0 2\"." )
>> -
>> -#define VLC_BANDS_TEXT N_( "Use VLC frequency bands" )
>> +         "Don't use presets, but manually specified bands. You need to "      \
>> +         "provide 10, 15, or 31 values between -20dB and 20dB, separated by " \
>> +         "spaces (e.g. \"0 2 4 2 0 -2 -4 -2 0 2\"). You may optionally "      \
>> +         "append a parameter \"v\" (valid for 10 values only) or \"i\" "      \
>> +         "(valid for 10, 15, and 31 values) to help VLC differentiate "       \
>> +         "between VLC bands and ISO bands, respectively." )
> No way our translators can translate that.

Why?

>> +#define VLC_BANDS_TEXT N_( "Use VLC frequency bands (deprecated)" )
>>   #define VLC_BANDS_LONGTEXT N_( \
>> -         "Use the VLC frequency bands. Otherwise, use the ISO Standard " \
>> -         "frequency bands." )
>> +         "This option is not used anymore; select \"10-band VLC equalizer\" " \
>> +         "as the equalizer type if you wish to use VLC frequency bands." )
> Sorry, but no. If it's deprecated, mark it as deprecated.

This is my first time deprecating a variable in a module, so I'm not 
sure how I'd go about that one.  (I often learn by example, so I simply 
followed what a developer did to deprecate the variables "sout-ts-bmin" 
and "sout-ts-bmax" in mux/mpeg/ts.c.  Did he or she do it wrong?)

Regards,

Ron Wright