[vlc-devel] [PATCH v3 05/10] equalizer: Add support for extra sets of ISO bands

[Ron Wright]

On 11/30/2015 07:52 AM, Ron Wright wrote:
>>> +#define VLC_BANDS_TEXT N_( "Use VLC frequency bands (deprecated)" )
>>>   #define VLC_BANDS_LONGTEXT N_( \
>>> -         "Use the VLC frequency bands. Otherwise, use the ISO 
>>> Standard " \
>>> -         "frequency bands." )
>>> +         "This option is not used anymore; select \"10-band VLC 
>>> equalizer\" " \
>>> +         "as the equalizer type if you wish to use VLC frequency 
>>> bands." )
>> Sorry, but no. If it's deprecated, mark it as deprecated.
>
> This is my first time deprecating a variable in a module, so I'm not 
> sure how I'd go about that one.  (I often learn by example, so I 
> simply followed what a developer did to deprecate the variables 
> "sout-ts-bmin" and "sout-ts-bmax" in mux/mpeg/ts.c.  Did he or she do 
> it wrong?)

Okay.  I'm going to guess that I mark it as deprecated by removing the 
VLC_BANDS_TEXT and VLC_BANDS_LONGTEXT defines and replacing add_bool( 
"equalizer-vlcfreqs", ... ) with add_obsolete_bool( "equalizer-vlcfreqs" 
).  That's the only other way I can think of to indicate that the 
variable is deprecated.  I was wondering whether this is what you want.

Regards,

Ron Wright