[vlc-devel] [PATCH] sout: existing code assumes ACCESS_OUT_CAN_SEEK is false on failure

Denis Charmet typx at dinauz.org
Thu Oct 1 16:31:55 CEST 2015


Hi,

It's only my opinion but I'm afraid that it's the code that is wrong not the public
header. While I personnaly don't care especially since it's the quickest fix, 
I still expect some people complaining that it broke their usecase.

Le jeudi 01 octobre 2015 à 10:03:31, Steve Lhomme a écrit :
> --- a/include/vlc_sout.h
> +++ b/include/vlc_sout.h
> @@ -90,7 +90,7 @@ struct sout_access_out_t
>  enum access_out_query_e
>  {
>      ACCESS_OUT_CONTROLS_PACE, /* arg1=bool *, can fail (assume true) */
> -    ACCESS_OUT_CAN_SEEK, /* arg1=bool *, can fail (assume true) */
> +    ACCESS_OUT_CAN_SEEK, /* arg1=bool *, can fail (assume false) */

Regards,

-- 
Denis Charmet - TypX
Le mauvais esprit est un art de vivre


More information about the vlc-devel mailing list