[vlc-devel] [PATCH] sout: existing code assumes ACCESS_OUT_CAN_SEEK is false on failure

Rémi Denis-Courmont remi at remlab.net
Thu Oct 1 18:30:31 CEST 2015


Le 2015-10-01 17:31, Denis Charmet a écrit :
> Hi,
>
> It's only my opinion but I'm afraid that it's the code that is wrong
> not the public header.

To the contrary, I think the patch is correct. As a general VLC coding 
rule, failing a capability control request means the capability is not 
implemented (alternatively, the request is not allowed to fail).

However, I share your concern that it might break some existing call 
sites (I have not checked).

-- 
Rémi Denis-Courmont
http://www.remlab.net/


More information about the vlc-devel mailing list