[vlc-devel] [PATCH 0/5] A 2nd subtitle feature

Jean-Baptiste Kempf jb at videolan.org
Tue Oct 6 12:35:43 CEST 2015

> This is my first ever contrib to open source,
> so any opinions would be great.

This is way better than the first version, tbh.

But, it would be nice to generalize it.

Moreover, the changes should be re-ordered in logical order: aka, first
core changes, then hotkey.

I don't think you should use a new spu-es variable, but just extend it:
we can have multiple video-tracks at the same time, "video-es", why
would be need multiple spu-es variables?

With my kindest regards,

Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device

More information about the vlc-devel mailing list