[vlc-devel] [PATCH] growl: Renamed Growl plugin to OS X Notifications
david.fuhrmann at gmail.com
Mon Oct 19 19:56:00 CEST 2015
> Am 19.10.2015 um 19:34 schrieb Rémi Denis-Courmont <remi at remlab.net>:
> Le 2015-10-19 20:15, epirat07 at gmail.com a écrit :
>> From: Marvin Scholz <epirat07 at gmail.com>
>> This renames the Growl plugin to OS X Notifications to highlight
>> the new capabilities and to not advertise Growl so much, as
> Nah. If the user explicitly requested Growl, you should most probably use Growl regardless of the OS version.
If I understood correctly, this still happens with the new module, regardless of the rename.
Question is still how the transition should happen, i.e. if we also rename the internal module name, it will break existing configs.
This part is seems wrong with the current patch - you change the modules short name, but do not adapt the interface code enabling / disabling the module.
Also, if you want to rename the module name, you should also adapt the makefile variables, and update MODULES_LIST and such.
More information about the vlc-devel