[vlc-devel] [PATCH] transcoding: avoid a divide by 0 when source video framerate is mistakenly set to 0 by a demuxer
fcvlcdev at free.fr
Wed Oct 28 18:33:09 CET 2015
Le 28/10/2015 14:02, Emeric Grange a écrit :
>> Yes you are right the default will probably be wrong, the goal was
>> only to avoid VLC segfaulting. My use case was trancoding mp4 file
>> with "DASH style" tracks from youtube, and the problem was not an
>> exotic framerate but just the mp4 parser unable to get framerate. Most
>> files are 24fps so 25 is not that far of.
>> Maybe the proper way to handle that situation is just to fail with an
>> error trace then.
> Anything new about this patch?
Unsure about it, but setting a default frame rate at transcode level
might be wrong.
I believe that's the role of the user module to compute frame rate by
itself, especially because it sees data, and then the fix belongs to there.
More information about the vlc-devel