[vlc-devel] [PATCH] transcoding: avoid a divide by 0 when source video framerate is mistakenly set to 0 by a demuxer

Emeric Grange emeric.grange at gmail.com
Wed Oct 28 19:47:16 CET 2015

2015-10-28 18:33 GMT+01:00 Francois Cartegnie <fcvlcdev at free.fr>:
> Le 28/10/2015 14:02, Emeric Grange a écrit :
>>> Hi,
>>> Yes you are right the default will probably be wrong, the goal was
>>> only to avoid VLC segfaulting. My use case was trancoding mp4 file
>>> with "DASH style" tracks from youtube, and the problem was not an
>>> exotic framerate but just the mp4 parser unable to get framerate. Most
>>> files are 24fps so 25 is not that far of.
>>> Maybe the proper way to handle that situation is just to fail with an
>>> error trace then.
>>> Emeric
>> Anything new about this patch?
> Unsure about it, but setting a default frame rate at transcode level
> might be wrong.
> I believe that's the role of the user module to compute frame rate by
> itself, especially because it sees data, and then the fix belongs to there.

A simple warning trace + exit would be better then?

> Francois
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

More information about the vlc-devel mailing list