[vlc-devel] [vlc-commits] audio_filter: only one module for all simple channel mixers

[Rémi Denis-Courmont]

Le 2015-09-02 11:50, Thomas Guillem a écrit :
>> > There was an other solution: the neon channel mixer being a 
>> submodule of the
>> > simple channel mixer but it is as complicated as my solution.
>>
>> Both are much more complicated than keeping separate modules like we
>> almost
>> always do. Not to mention what happens if someone wants to add a 
>> third
>> platform there...
>
> It's quite easy to add a third platform here: add a 
> simple_<platform>.h
> and do like I did for simple_neon.h.

If it were so easy, how come you did not even get it right the first 
time?
Also now, how would one pass different compiler flags (for different 
ISAs)?

(Not to speak of the flexibility of including/excluding plugins.)

> I know that this MACRO magic is not as clear as before but I 
> preferred
> that the neon mixer benefits from the patches of the general mixer.

So it will get all the updates. In other words, it is much more likely 
to break next time someone modifies the non-NEON variant.

-- 
Rémi Denis-Courmont
http://www.remlab.net/