[vlc-devel] [PATCH 3/4] demux: adaptative: fix compilation on OS/2

[Rémi Denis-Courmont]

Le 2015-09-07 09:56, KO Myung-Hun a écrit :
> diff --git a/modules/demux/Makefile.am b/modules/demux/Makefile.am
> index cf290df..f464251 100644
> --- a/modules/demux/Makefile.am
> +++ b/modules/demux/Makefile.am
> @@ -381,6 +381,9 @@ libadaptative_plugin_la_SOURCES +=
> $(libadaptative_dash_SOURCES)
>  libadaptative_plugin_la_SOURCES += demux/adaptative/adaptative.cpp
>  libadaptative_plugin_la_SOURCES += demux/mp4/libmp4.c 
> demux/mp4/libmp4.h
>  libadaptative_plugin_la_CXXFLAGS = $(AM_CFLAGS) 
> -I$(srcdir)/demux/adaptative
> +if HAVE_OS2
> +libadaptative_plugin_la_CXXFLAGS += -std=gnu++11
> +endif

This makes no sense at multiple levels. Firstly, configure already 
checks for this flag, so either either the configure check or your 
compiler is broken, NOT the VLC makefiles. Secondly, if VLC only works 
with C(++)11, then we need to require it in configure, not make it 
optional.

(I never understood what the point of the optional C++11 check was 
insofar as it was optional.)

>  libadaptative_plugin_la_LIBADD = $(SOCKET_LIBS) $(LIBM)
>  if HAVE_ZLIB
>  libadaptative_plugin_la_LIBADD += -lz

-- 
Rémi Denis-Courmont
http://www.remlab.net/