[vlc-devel] [PATCH 3/4] demux: adaptative: fix compilation on OS/2

[KO Myung-Hun]

Hi/2.

Rémi Denis-Courmont wrote:
> Le 2015-09-07 09:56, KO Myung-Hun a écrit :
>> diff --git a/modules/demux/Makefile.am b/modules/demux/Makefile.am
>> index cf290df..f464251 100644
>> --- a/modules/demux/Makefile.am
>> +++ b/modules/demux/Makefile.am
>> @@ -381,6 +381,9 @@ libadaptative_plugin_la_SOURCES +=
>> $(libadaptative_dash_SOURCES)
>>  libadaptative_plugin_la_SOURCES += demux/adaptative/adaptative.cpp
>>  libadaptative_plugin_la_SOURCES += demux/mp4/libmp4.c demux/mp4/libmp4.h
>>  libadaptative_plugin_la_CXXFLAGS = $(AM_CFLAGS)
>> -I$(srcdir)/demux/adaptative
>> +if HAVE_OS2
>> +libadaptative_plugin_la_CXXFLAGS += -std=gnu++11
>> +endif
> 
> This makes no sense at multiple levels. Firstly, configure already
> checks for this flag, so either either the configure check or your
> compiler is broken, NOT the VLC makefiles. Secondly, if VLC only works
> with C(++)11, then we need to require it in configure, not make it
> optional.
> 
> (I never understood what the point of the optional C++11 check was
> insofar as it was optional.)
> 

It was best to define __STDC_xxx_MACROS in vlc_fixups.h at the beginning
regardless of C++ version.

Anyway, this is another patch.


-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-demux-adaptative-fix-compilation-on-OS-2.patch
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20150916/6270899b/attachment.ksh>